Fix/337 move metrics to cache refresh#338
Open
gimballock wants to merge 1 commit intostratum-mining:mainfrom
Open
Fix/337 move metrics to cache refresh#338gimballock wants to merge 1 commit intostratum-mining:mainfrom
gimballock wants to merge 1 commit intostratum-mining:mainfrom
Conversation
gimballock
force-pushed
the
fix/337-move-metrics-to-cache-refresh
branch
3 times, most recently
from
56a1252 to
a0e972e
Compare
Author
|
Addresses #337 |
gimballock
force-pushed
the
fix/337-move-metrics-to-cache-refresh
branch
4 times, most recently
from
0a55dce to
13457ee
Compare
gimballock
changed the title
gimballock
force-pushed
the
fix/337-move-metrics-to-cache-refresh
branch
2 times, most recently
from
832f7db to
04dfe60
Compare
…hotCache::refresh (stratum-mining#337) Move all Prometheus gauge updates (set + stale-label removal) out of the /metrics HTTP handler and into SnapshotCache::refresh(), which runs as a periodic background task. This eliminates the GaugeVec reset gap where label series momentarily disappeared on every scrape. Changes: - SnapshotCache now owns PrometheusMetrics and PreviousLabelSets - refresh() updates snapshot data AND Prometheus gauges atomically - /metrics handler reduced to: set uptime gauge, gather, encode - ServerState simplified (no more PreviousLabelSets or Mutex) - Tests updated to wire metrics through cache via with_metrics() - Integration tests: replace fixed-sleep assertions with poll_until_metric_gte (100ms poll, 5s deadline) for CI resilience - Clone impl preserves previous_labels for correct stale-label detection - debug-level tracing on stale label removal errors - debug_assert on with_metrics double-attachment Closes stratum-mining#337
gimballock
force-pushed
the
fix/337-move-metrics-to-cache-refresh
branch
from
04dfe60 to
1b016e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.